Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mixed search spaces notebook #818

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Add mixed search spaces notebook #818

merged 4 commits into from
Feb 7, 2024

Conversation

khurram-ghani
Copy link
Collaborator

Related issue(s)/PRs: None

Summary

PR adds initial notebook showing BO over mixed discrete and continuous search spaces.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

@khurram-ghani khurram-ghani marked this pull request as ready for review February 2, 2024 14:40
hstojic
hstojic approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@hstojic hstojic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments, but looks good

docs/notebooks/mixed_search_spaces.pct.py Outdated Show resolved Hide resolved
docs/notebooks/mixed_search_spaces.pct.py Show resolved Hide resolved
vpicheny
vpicheny approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@vpicheny vpicheny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few minor comments but overall good!

@khurram-ghani khurram-ghani merged commit 9c7a194 into develop Feb 7, 2024
12 checks passed
@khurram-ghani khurram-ghani deleted the khurram/mixed_search_spaces_nb branch February 7, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstojic hstojic hstojic approved these changes

@vpicheny vpicheny vpicheny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khurram-ghani @hstojic @vpicheny